Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #4276] Upgrade poster and geonode/tests for Python 2.7/3 compatibility #5405

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

mtnorthcott
Copy link
Contributor

PR to update tests module to be Python 2.7/3 cross-compatible as part of #4276. This includes the upgrade to the now deprecated poster dependency used for testing file uploads. I have replaced this package with requests and requests-toolbelt which have similar multipart capability.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 11, 2019
@mtnorthcott mtnorthcott changed the title [Issue #4276] Upgrade poster and goenode/tests for Python 2.7/3 compatibility [Issue #4276] Upgrade poster and geonode/tests for Python 2.7/3 compatibility Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #5405 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5405   +/-   ##
=======================================
  Coverage   57.55%   57.55%           
=======================================
  Files         172      172           
  Lines       19264    19264           
  Branches     2996     2996           
=======================================
  Hits        11087    11087           
  Misses       7156     7156           
  Partials     1021     1021

@mtnorthcott mtnorthcott reopened this Dec 12, 2019
@afabiani afabiani added the python-3 Stuff related to https://github.com/GeoNode/geonode/issues/4276 label Dec 12, 2019
@afabiani afabiani added this to the 3.0 milestone Dec 12, 2019
@afabiani afabiani merged commit 2fc9bf6 into GeoNode:master Dec 12, 2019
@mtnorthcott mtnorthcott deleted the tests_upgrade branch December 12, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed python-3 Stuff related to https://github.com/GeoNode/geonode/issues/4276
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants