Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Closes #4276] GNIP-64: Python 3 & Django 2 Upgrade #5511

Merged
merged 11 commits into from
Jan 22, 2020
Merged

[Closes #4276] GNIP-64: Python 3 & Django 2 Upgrade #5511

merged 11 commits into from
Jan 22, 2020

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Jan 14, 2020 •
edited
Loading

Co-authored-by: Dingding Fan [email protected]
Co-authored-by: Dana Lambert [email protected]
Co-authored-by: Matthew Northcott [email protected]
Co-authored-by: Tobi @geotob https://github.com/GeoTob

@afabiani afabiani added the python-3 Stuff related to https://github.com/GeoNode/geonode/issues/4276 label Jan 14, 2020
@afabiani afabiani added this to the 3.0 milestone Jan 14, 2020
@afabiani afabiani self-assigned this Jan 14, 2020
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 14, 2020
@afabiani afabiani force-pushed the bump_to_python3 branch 5 times, most recently from 77b6580 to 606a203 Compare January 16, 2020 08:46
@afabiani afabiani force-pushed the bump_to_python3 branch 2 times, most recently from 83deaa3 to 27a6cce Compare January 16, 2020 11:45
@afabiani
Copy link
Member Author

afabiani commented Jan 16, 2020 •
edited
Loading

Almost all working on Python3 / Django 2.2.9

Known issues:

  • pycsw encoding error; waiting for a reply on this PR
  • Set Thumbnail from web interface not producing a good image; the bbox and dimensions seem to be wrong

There might be other instabilities around, especially caused by "str vs bytes" encoding issues.

TODO:

  • Publish official releases of requirements and geonode libraries

@afabiani afabiani requested a review from giohappy January 16, 2020 11:51
@afabiani afabiani force-pushed the bump_to_python3 branch 2 times, most recently from 0a2b018 to 2da872c Compare January 16, 2020 17:10
@DingDingFan0207
Copy link
Contributor

DingDingFan0207 commented Jan 17, 2020 •
edited
Loading

when running paver start this error was returned:
Error: Invalid or corrupt jarfile /home/dingdingfan/geonode_p3_manual_testing/geonode/downloaded/jetty-runner-9.4.7.v20170914.jar The logs are available at /home/dingdingfan/geonode_p3_manual_testing/geonode/geoserver/jetty.log
This particular file does exist (it had been created correctly). Please refer to https://github.com/GeoNode/geonode/pull/5516 (Update JETTY_RUNNER_URL to secure HTTPS equivalent #5516).

@afabiani afabiani force-pushed the bump_to_python3 branch 4 times, most recently from ffc0551 to 1ea85bf Compare January 17, 2020 15:47
@afabiani afabiani force-pushed the bump_to_python3 branch 6 times, most recently from 5840498 to a86aca2 Compare January 20, 2020 14:16
@afabiani afabiani force-pushed the bump_to_python3 branch 6 times, most recently from e8be132 to 9ef1fa8 Compare January 21, 2020 10:58
[Issue #4276] Fixes to core modules for Python 3
50f821e 
Co-authored-by: Dingding Fan <[email protected]>
Co-authored-by: Dana Lambert <[email protected]>
@afabiani afabiani force-pushed the bump_to_python3 branch 6 times, most recently from d64fdd1 to b771b9d Compare January 21, 2020 22:30
Merge branch 'master' of https://github.com/GeoNode/geonode into bump…
45cfb24 
…_to_python3

# Conflicts:
#	scripts/spcgeonode/docker-compose.override.yml
#	scripts/spcgeonode/docker-compose.yml
@afabiani afabiani changed the title - Bump to Python 3 [Closes #4276] GNIP-64: Python 3 & Django 2 Upgrade Jan 22, 2020
@afabiani afabiani merged commit b239942 into master Jan 22, 2020
@afabiani afabiani deleted the bump_to_python3 branch January 22, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giohappy giohappy Awaiting requested review from giohappy

Assignees

@afabiani afabiani

Labels
cla-signed CLA Bot: community license agreement signed python-3 Stuff related to https://github.com/GeoNode/geonode/issues/4276
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

GNIP-64: Python 3 & Django 2 Upgrade
2 participants
@afabiani @DingDingFan0207