Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #5555] Improve speed of terminating geoserver #5539

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

mtnorthcott
Copy link
Contributor

@mtnorthcott mtnorthcott commented Jan 22, 2020

PR to stop geoserver using psutil instead of os.kill and sleeping as termination typically takes <30 seconds.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #5539 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5539   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files         171      171           
  Lines       19526    19526           
  Branches     3196     3196           
=======================================
  Hits        11241    11241           
  Misses       7277     7277           
  Partials     1008     1008

@afabiani
Copy link
Member

@mtnorthcott let's please attach a ticket to this PR. Thanks.

@afabiani afabiani added this to the 3.0 milestone Jan 23, 2020
@mtnorthcott mtnorthcott changed the title Improve speed of terminating geoserver [Issue #5555] Improve speed of terminating geoserver Jan 23, 2020
@afabiani afabiani added the feature A new feature to be added to the codebase label Jan 24, 2020
@afabiani afabiani merged commit e0da994 into GeoNode:master Jan 24, 2020
@mtnorthcott mtnorthcott deleted the improve_paver_stop branch January 25, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed feature A new feature to be added to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants