Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #6843] Remove six library #6839

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Conversation

burner761
Copy link
Contributor

@burner761 burner761 commented Jan 19, 2021

remove all uses of the six library in the project.

@cla-bot
Copy link

cla-bot bot commented Jan 19, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 6 alerts and fixes 1 when merging ec21baa into 4f780eb - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 2 for 'input' function used in Python 2
  • 1 for Unused local variable

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@burner761 burner761 changed the title removes use of six library [6795]removes use of six library Jan 19, 2021
afabiani
afabiani previously approved these changes Jan 19, 2021
@cla-bot
Copy link

cla-bot bot commented Jan 19, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 6 alerts and fixes 1 when merging f9a8f79 into 79fac3a - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 2 for 'input' function used in Python 2
  • 1 for Unused local variable

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@afabiani
Copy link
Member

@burner761 can you please take a look at the new LGTM issues introduced with this PR?

@cla-bot
Copy link

cla-bot bot commented Jan 19, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 4 alerts and fixes 1 when merging 2796803 into 79fac3a - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2
  • 1 for Unused local variable
  • 1 for Unused import

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

Copy link
Contributor

@mtnorthcott mtnorthcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

six can still be removed from the following:

  • geonode/social/tests.py
  • geonode/geoapps/api/serializers.py
  • geonode/geoserver/tasks.py
  • requirements.txt

@cla-bot
Copy link

cla-bot bot commented Jan 20, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 4 alerts and fixes 1 when merging 903126d into c796bac - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2
  • 1 for Unused local variable
  • 1 for Unused import

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 21, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2021

This pull request introduces 2 alerts and fixes 1 when merging c4a1109 into 2aaea8e - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #6839 (2aaea8e) into master (4e4bb7b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6839      +/-   ##
==========================================
- Coverage   51.88%   51.87%   -0.01%     
==========================================
  Files         573      573              
  Lines       40848    40848              
  Branches     5500     5500              
==========================================
- Hits        21195    21191       -4     
- Misses      18314    18317       +3     
- Partials     1339     1340       +1     

@mtnorthcott mtnorthcott changed the title [6795]removes use of six library [Issue #6843] Remove six library Jan 21, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2021

This pull request introduces 2 alerts and fixes 1 when merging ae11d3b into 7440156 - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2021

This pull request introduces 2 alerts and fixes 1 when merging 4f8b714 into 4e4bb7b - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@afabiani afabiani added this to the 3.2 milestone Jan 27, 2021
Copy link
Member

@afabiani afabiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts, moreover see if it is possible to solve the new LGTM issues.

@lgtm-com
Copy link

lgtm-com bot commented Feb 9, 2021

This pull request introduces 2 alerts and fixes 1 when merging 7925a95 into 0fff86a - view on LGTM.com

new alerts:

  • 2 for 'input' function used in Python 2

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@afabiani afabiani merged commit 372123d into GeoNode:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants