-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #6843] Remove six library #6839
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This pull request introduces 6 alerts and fixes 1 when merging ec21baa into 4f780eb - view on LGTM.com new alerts:
fixed alerts:
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This pull request introduces 6 alerts and fixes 1 when merging f9a8f79 into 79fac3a - view on LGTM.com new alerts:
fixed alerts:
|
@burner761 can you please take a look at the new LGTM issues introduced with this PR? |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This pull request introduces 4 alerts and fixes 1 when merging 2796803 into 79fac3a - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
six
can still be removed from the following:
- geonode/social/tests.py
- geonode/geoapps/api/serializers.py
- geonode/geoserver/tasks.py
- requirements.txt
2796803
to
903126d
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
This pull request introduces 4 alerts and fixes 1 when merging 903126d into c796bac - view on LGTM.com new alerts:
fixed alerts:
|
903126d
to
c4a1109
Compare
This pull request introduces 2 alerts and fixes 1 when merging c4a1109 into 2aaea8e - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6839 +/- ##
==========================================
- Coverage 51.88% 51.87% -0.01%
==========================================
Files 573 573
Lines 40848 40848
Branches 5500 5500
==========================================
- Hits 21195 21191 -4
- Misses 18314 18317 +3
- Partials 1339 1340 +1 |
This pull request introduces 2 alerts and fixes 1 when merging ae11d3b into 7440156 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 4f8b714 into 4e4bb7b - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some conflicts, moreover see if it is possible to solve the new LGTM issues.
This pull request introduces 2 alerts and fixes 1 when merging 7925a95 into 0fff86a - view on LGTM.com new alerts:
fixed alerts:
|
remove all uses of the six library in the project.