[Issue #6843] Simplify long conditionals #6846
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
There was a problem hiding this comment.
Please check the associated issue #6809 as this has specific information on what this PR should involve. Instances of if variable is None: are not considered long conditionals and should be preferred as if not variable: is not specific. Explicit is better than implicit.
burner761
force-pushed
the
danielLowe/6809-Simplify-long-conditionals
branch
from
0daa951 to
7bf5c60
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @DanieSimonlLowe on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
This pull request introduces 1 alert when merging 7bf5c60 into c796bac - view on LGTM.com new alerts:
|
burner761
force-pushed
the
danielLowe/6809-Simplify-long-conditionals
branch
from
7bf5c60 to
f44094d
Compare
mtnorthcott
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6846 +/- ##
==========================================
- Coverage 51.88% 51.87% -0.01%
==========================================
Files 573 573
Lines 40848 40846 -2
Branches 5500 5498 -2
==========================================
- Hits 21195 21190 -5
- Misses 18314 18315 +1
- Partials 1339 1341 +2 |
simplifyed some long conditionals.