Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #6942] Defer and preload assets to improve page loading times #6943

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

mtnorthcott
Copy link
Contributor

@mtnorthcott mtnorthcott commented Feb 10, 2021

Closes #6942

PR to defer/preload certain assets to improve page loading times. While this helps the loading times significantly, there is the side effect that some assets will move position on-screen during the loading period (quantified by the cumulative layout shift in the screenshots below)

Before

Screenshot from 2021-02-10 13-41-36

After

Screenshot from 2021-02-10 13-47-44

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 10, 2021
@mtnorthcott mtnorthcott changed the title Defer and preload assets to improve page loading times [Issue #6942] Defer and preload assets to improve page loading times Feb 10, 2021
@afabiani
Copy link
Member

@mtnorthcott very nice thanks

@afabiani afabiani merged commit f0b278d into GeoNode:master Feb 10, 2021
@afabiani
Copy link
Member

@mtnorthcott we should revert this because we noticed a lot of regressions while testing the UI.
Deferring stuff improves speed but also introduces several issues:

  1. JS errors at loading time/init time
  2. UI glitches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve page load times
2 participants