[Backport][Fixes #7644] Api - filter favorite in /resources endpoint doesn't return all favorites item #7646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the
api/v2/resources/{id}/favorite
endpoint, thecontent_type
of the resource is set asresourcebase
in the favorite table, while from the Layer/Document/app table, is correctly assigned ->['document', 'geostory', 'map', 'layer']
So this means that the
FavoriteFilter
when is called, filter for theresource_type
available in the queryset (for reducing the weight of the query)With this PR I want to assign the correct subtype of the resource even if a
resourcebase
is sent to the favorite creationChecklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.