Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7762] Add keyword to harvested resources #7758

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

meomancer
Copy link
Contributor

@meomancer meomancer commented Jul 9, 2021

References: #7762

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot
Copy link

cla-bot bot commented Jul 9, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @meomancer on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@meomancer
Copy link
Contributor Author

meomancer commented Jul 9, 2021

This fix geosolutions-it/nexus-geonode#285
This fix #7762

  • Add harvester name as default keyword (and lower it) with upcoming keywords
  • Update geonode resource with keywords and regions from harvester data.

Selection_325

Selection_327

CC @ricardogsilva

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #7758 (c1bb949) into master (dd84cf6) will increase coverage by 24.96%.
The diff coverage is 0.00%.

❗ Current head c1bb949 differs from pull request most recent head 3e0a776. Consider uploading reports for the commit 3e0a776 to get more accurate results

@@             Coverage Diff             @@
##           master    #7758       +/-   ##
===========================================
+ Coverage   31.67%   56.64%   +24.96%     
===========================================
  Files         686      685        -1     
  Lines       43630    43604       -26     
  Branches     5576     5581        +5     
===========================================
+ Hits        13820    24699    +10879     
+ Misses      29043    17467    -11576     
- Partials      767     1438      +671     

@meomancer meomancer changed the title Update wms harvester to be able to save to geonode [Fixes #7762] Add keyword to harvested resources Jul 9, 2021
@cla-bot
Copy link

cla-bot bot commented Jul 9, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @meomancer on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 9, 2021
@afabiani afabiani added this to the 4.0.0 milestone Jul 14, 2021
@giohappy giohappy requested a review from ricardogsilva July 16, 2021 09:05
@ricardogsilva
Copy link
Member

@meomancer the PR looks good to me, but please make sure to update it with the latest changes from master before I give my final review and approval

@ricardogsilva
Copy link
Member

@afabiani the failing test here seems to be unrelated to the PR, do you agree?

@afabiani
Copy link
Member

@ricardogsilva yes correct

@afabiani afabiani merged commit 22123cc into GeoNode:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants