Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7771] Use URL reversing (#7746) #7788

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jul 12, 2021

References: #7771

Cherry-pick of commit 4ff625a

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

etj and others added 2 commits July 12, 2021 11:18
* [GeoNode#7740] Use URL reversing

* [GeoNode#7740] Use URL reversing: po files

* [GeoNode#7740] Use URL reversing: more changes in po files

* [GeoNode#7740] Use URL reversing

* [GeoNode#7740] Use URL reversing: py files

* [GeoNode#7740] Use URL reversing: py files

* [GeoNode#7740] Use URL reversing - fixes

* [GeoNode#7740] Use URL reversing - fixes

* [GeoNode#7740] Use URL reversing - fixes
@mattiagiupponi mattiagiupponi requested a review from afabiani July 12, 2021 09:41
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 12, 2021
@mattiagiupponi mattiagiupponi changed the title [#77717] Use URL reversing (#7746) [#7771] Use URL reversing (#7746) Jul 12, 2021
@mattiagiupponi mattiagiupponi marked this pull request as draft July 12, 2021 10:39
@mattiagiupponi
Copy link
Contributor Author

back to draft until the tests are fixed

@mattiagiupponi mattiagiupponi marked this pull request as ready for review July 12, 2021 11:25
@mattiagiupponi
Copy link
Contributor Author

back to draft until the tests are fixed

Fixed, waiting for build results

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #7788 (9ebedb8) into master (d81d86d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7788      +/-   ##
==========================================
+ Coverage   56.64%   56.67%   +0.03%     
==========================================
  Files         685      685              
  Lines       43600    43605       +5     
  Branches     5581     5581              
==========================================
+ Hits        24698    24714      +16     
+ Misses      17465    17453      -12     
- Partials     1437     1438       +1     

@mattiagiupponi mattiagiupponi changed the title [#7771] Use URL reversing (#7746) [Fixes #7771] Use URL reversing (#7746) Jul 12, 2021
@giohappy giohappy merged commit 4b97410 into GeoNode:master Jul 12, 2021
@afabiani afabiani added this to the 4.0.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants