Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7795] URL tests use own URLs #7796

Merged
merged 4 commits into from
Jul 14, 2021
Merged

[Fixes #7795] URL tests use own URLs #7796

merged 4 commits into from
Jul 14, 2021

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jul 13, 2021

References: #7795

Remove defined urls in tests file, importing geonode.urls.
Waiting for circleCI feedback

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 13, 2021
@mattiagiupponi mattiagiupponi changed the title [#7795] URL tests use own URLs WIP - [#7795] URL tests use own URLs Jul 13, 2021
@mattiagiupponi mattiagiupponi requested review from afabiani and etj July 14, 2021 07:39
@mattiagiupponi mattiagiupponi self-assigned this Jul 14, 2021
@mattiagiupponi mattiagiupponi changed the title WIP - [#7795] URL tests use own URLs [#7795] URL tests use own URLs Jul 14, 2021
@etj etj linked an issue Jul 14, 2021 that may be closed by this pull request
@afabiani afabiani changed the title [#7795] URL tests use own URLs [Fixes #7795] URL tests use own URLs Jul 14, 2021
@afabiani afabiani added this to the 3.2.1 milestone Jul 14, 2021
@afabiani afabiani merged commit fff831d into 3.2.x Jul 14, 2021
@afabiani afabiani deleted the patch_ISSUE_7740 branch July 14, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL tests use own URLs
2 participants