Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7882][32x] Error in handling favorite #7883

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

etj
Copy link
Contributor

@etj etj commented Jul 28, 2021

Fix API error when FAVORITE app is disabled.
Refers to #7882

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy added this to the 3.2.2 milestone Jul 28, 2021
@giohappy giohappy merged commit 8aa267b into GeoNode:3.2.x Jul 28, 2021
@giohappy giohappy added the backport 3.3.x PR should be backported to target version label Jul 28, 2021
afabiani pushed a commit that referenced this pull request Jul 29, 2021
afabiani pushed a commit that referenced this pull request Jul 29, 2021
(cherry picked from commit 8aa267b)
(cherry picked from commit 94a11e0)
@afabiani
Copy link
Member

@giohappy @etj ported on both 3.3.x and master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.3.x PR should be backported to target version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants