Fix view_in_or_basicauth decorator not working in the context of the REST API

[ricardogsilva]

This PR changes the geonode.decorators.view_or_basicauth() function in order to get the current user by looking at the request directly instead of using django.contrib.auth.get_user(). This change was done in order to allow dataset uploads via REST API to work.

The REST API's /api/v2/uploads/upload/ endpoint eventually ends up using view_or_basicauth in order to check whether to allow the upload view to get called.

When using the REST API via a non-browser client, with OAuth2, there will not be any django session where the user is already stored. This means that django.contrib.auth.get_user() will fail, as it relies on sessions.

The proposed implementation simply uses request.user in order to get the current user. This ought to work on both occasions, as it relies on the django auth middleware having already performed its duty and enhanced the django request object with a user (be it a regular user or an AnonymousUser).

fixes #8541

[gitguardian]

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret

Secret	Commit	Filename	Detected At
Django Secret Key	0b8cbac	.env_dev	12:32 December 23rd, 2021	View secret
Django Secret Key	0b8cbac	.env_local	12:32 December 23rd, 2021	View secret
Django Secret Key	9669e80	.devcontainer/.env	12:32 December 23rd, 2021	View secret
Django Secret Key	5fa8dac	.devcontainer/.env	12:32 December 23rd, 2021	View secret
Django Secret Key	5fa8dac	.env_dev	12:32 December 23rd, 2021	View secret
Django Secret Key	5fa8dac	.env_local	12:32 December 23rd, 2021	View secret
Generic High Entropy Secret	354764e	.env	21:32 May 27th, 2021	View secret
Django Secret Key	e5cf581	.env_dev	14:37 September 29th, 2021	View secret
Generic High Entropy Secret	e5cf581	.env_dev	14:37 September 29th, 2021	View secret
Django Secret Key	e5cf581	.env_local	14:37 September 29th, 2021	View secret
Django Secret Key	e5cf581	.env_test	14:37 September 29th, 2021	View secret
Generic High Entropy Secret	e5cf581	.env_test	14:37 September 29th, 2021	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

[lgtm-com]

This pull request introduces 2 alerts when merging f51ef29 into 28357a5 - view on LGTM.com

new alerts:

• 1 for Unused import
• 1 for Information exposure through an exception

[lgtm-com]

This pull request introduces 1 alert when merging 06b08ae into 28357a5 - view on LGTM.com

new alerts:

• 1 for Information exposure through an exception

[codecov]

Codecov Report

Merging #8543 (06b08ae) into master (e7d3115) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8543      +/-   ##
==========================================
+ Coverage   58.48%   58.60%   +0.11%     
==========================================
  Files         780      780              
  Lines       46483    46480       -3     
  Branches     6917     6916       -1     
==========================================
+ Hits        27187    27240      +53     
+ Misses      17788    17737      -51     
+ Partials     1508     1503       -5     

[giohappy]

@ricardogsilva shouldn't we backport this to 3.3.x too?