Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9821] Time serie selection handled by the advanced metadata panel #9840

Merged
merged 25 commits into from
Aug 26, 2022

Conversation

mattiagiupponi
Copy link
Contributor

related to #9821

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 4.0.1 milestone Aug 10, 2022
@mattiagiupponi mattiagiupponi self-assigned this Aug 10, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #9840 (c50898b) into master (a85faae) will decrease coverage by 0.01%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master    #9840      +/-   ##
==========================================
- Coverage   61.39%   61.38%   -0.02%     
==========================================
  Files         823      823              
  Lines       50328    50400      +72     
  Branches     7746     7761      +15     
==========================================
+ Hits        30898    30936      +38     
- Misses      17753    17782      +29     
- Partials     1677     1682       +5     

@mattiagiupponi mattiagiupponi requested a review from etj August 10, 2022 08:54
@mattiagiupponi mattiagiupponi marked this pull request as draft August 10, 2022 16:24
@mattiagiupponi
Copy link
Contributor Author

back to draft, some development is missing

@mattiagiupponi mattiagiupponi removed the request for review from etj August 10, 2022 16:24
@mattiagiupponi mattiagiupponi changed the title [Fixes #9821] Time serie selection handled by the advanced metadata panel WIP - [Fixes #9821] Time serie selection handled by the advanced metadata panel Aug 11, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2022

This pull request introduces 1 alert when merging faed0ce into a313150 - view on LGTM.com

new alerts:

  • 1 for Unused import

@@ -920,12 +924,13 @@ def final_step(upload_session, user, charset="UTF-8", dataset_id=None):
with transaction.atomic():
resource_manager.set_permissions(
None, instance=saved_dataset, permissions=permissions, created=created)
resource_manager.exec(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved before the update, in this case the time_serie is already configured before sync the resource with geoserver

@mattiagiupponi mattiagiupponi marked this pull request as ready for review August 25, 2022 14:17
@mattiagiupponi mattiagiupponi changed the title WIP - [Fixes #9821] Time serie selection handled by the advanced metadata panel [Fixes #9821] Time serie selection handled by the advanced metadata panel Aug 25, 2022
@afabiani afabiani merged commit 762c7c9 into master Aug 26, 2022
@afabiani afabiani deleted the ISSUE_9821 branch August 26, 2022 09:43
github-actions bot pushed a commit that referenced this pull request Aug 26, 2022
…anel (#9840)

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9861]Cannot open metadata detail with thesaurus installed

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] Fix wrong subtype in case of timeserie dataset

* [Fixes #9821] Fix circleci build
afabiani pushed a commit that referenced this pull request Aug 26, 2022
…anel (#9840) (#9914)

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] add new attribute to time series

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9861]Cannot open metadata detail with thesaurus installed

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] Time serie selection handled by the advanced metadata panel

* [Fixes #9821] Fix wrong subtype in case of timeserie dataset

* [Fixes #9821] Fix circleci build

Co-authored-by: mattiagiupponi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants