Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test on extra metadata #9859

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Aug 17, 2022

References: #9859

corner case was missing

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from etj August 17, 2022 10:13
@mattiagiupponi mattiagiupponi self-assigned this Aug 17, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 17, 2022
Copy link
Contributor

@etj etj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be squeezed and referred to issue #9842 in commit message

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #9859 (1e2d0f6) into master (ca04bcf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #9859   +/-   ##
=======================================
  Coverage   61.34%   61.35%           
=======================================
  Files         822      822           
  Lines       50300    50312   +12     
  Branches     7746     7746           
=======================================
+ Hits        30857    30869   +12     
  Misses      17764    17764           
  Partials     1679     1679           

@mattiagiupponi mattiagiupponi merged commit a313150 into master Aug 17, 2022
@mattiagiupponi mattiagiupponi deleted the add_test_case_on_metadata branch August 17, 2022 10:50
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
[Fixes #9842] Extra metadata endpoint return 403 even if the user has view perms, add new test
mattiagiupponi added a commit that referenced this pull request Aug 17, 2022
[Fixes #9842] Extra metadata endpoint return 403 even if the user has view perms, add new test

Co-authored-by: mattiagiupponi <[email protected]>
@afabiani afabiani added this to the 4.0.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants