Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9881] AttributeError on viewing recent activities #9907

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

marthamareal
Copy link
Contributor

References #9881 ## Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 25, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2022

This pull request introduces 2 alerts when merging e26705c into c3d3eb6 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@marthamareal marthamareal marked this pull request as draft August 25, 2022 10:41
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #9907 (2c6a368) into master (c3d3eb6) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #9907      +/-   ##
==========================================
+ Coverage   61.37%   61.39%   +0.01%     
==========================================
  Files         822      823       +1     
  Lines       50338    50328      -10     
  Branches     7747     7746       -1     
==========================================
+ Hits        30897    30898       +1     
+ Misses      17763    17753      -10     
+ Partials     1678     1677       -1     

@marthamareal marthamareal self-assigned this Aug 25, 2022
@marthamareal marthamareal marked this pull request as ready for review August 25, 2022 12:29
@afabiani afabiani added this to the 4.0.1 milestone Aug 25, 2022
@mattiagiupponi mattiagiupponi merged commit ad8fcae into master Aug 25, 2022
@mattiagiupponi mattiagiupponi deleted the ISSUE_9881 branch August 25, 2022 15:30
github-actions bot pushed a commit that referenced this pull request Aug 25, 2022
* -[Fixes #9881] AttributeError on viewing recent activities

* - remove actions about comments
mattiagiupponi pushed a commit that referenced this pull request Aug 25, 2022
)

* -[Fixes #9881] AttributeError on viewing recent activities

* - remove actions about comments

Co-authored-by: NAGGINDA MARTHA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants