Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9878] drf_spectacular error breaks redoc and swagger-ui schemas #9908

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

marthamareal
Copy link
Contributor

@marthamareal marthamareal commented Aug 25, 2022

references #9878

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@marthamareal marthamareal self-assigned this Aug 25, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #9908 (c76f551) into master (ad8fcae) will increase coverage by 25.73%.
The diff coverage is 100.00%.

❗ Current head c76f551 differs from pull request most recent head d2695ce. Consider uploading reports for the commit d2695ce to get more accurate results

@@             Coverage Diff             @@
##           master    #9908       +/-   ##
===========================================
+ Coverage   35.63%   61.37%   +25.73%     
===========================================
  Files         823      822        -1     
  Lines       50328    50338       +10     
  Branches     7746     7747        +1     
===========================================
+ Hits        17936    30895    +12959     
+ Misses      31228    17766    -13462     
- Partials     1164     1677      +513     

@mattiagiupponi mattiagiupponi merged commit a85faae into master Aug 25, 2022
@mattiagiupponi mattiagiupponi deleted the ISSUE_9878 branch August 25, 2022 16:21
@mattiagiupponi mattiagiupponi added this to the 4.0.1 milestone Aug 25, 2022
github-actions bot pushed a commit that referenced this pull request Aug 26, 2022
afabiani pushed a commit that referenced this pull request Aug 26, 2022
…mas (#9908) (#9910)

Co-authored-by: mattiagiupponi <[email protected]>

Co-authored-by: NAGGINDA MARTHA <[email protected]>
Co-authored-by: mattiagiupponi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants