fix(MainWindow): check if last_widget is a GtkWidget before using #1061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that checking if last_widget (weak ref) is null is not enough, we actually have to check if it's also a widget.Turns out that using weak ref at all is segfaulty 🤷 let's just use a normal ref and hope for no memory leaks (couldn't find any in my testing, we do try to clear the ref as often as possible (after the focus has been used, when the model gets cleared))
On my side, that resulted in a CRITICAL, but it turns out it can segfault too
fix: #1059
When I'm in a 'why is this happening' competition and my opponent is vala