Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Timeline): entity queue #234

Merged
merged 1 commit into from
May 9, 2023
Merged

feat(Timeline): entity queue #234

merged 1 commit into from
May 9, 2023

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented May 8, 2023

fix: #126

How does this work?

  • If the user's scroll position is near the top: new posts get prepended
  • If the user's scroll position is not near the top: new posts get added into an array and when the user scrolls to near the top, they get prepended

@GeopJr GeopJr merged commit 98ca2ae into main May 9, 2023
@GeopJr GeopJr deleted the feat/timeline/entity_queue branch May 9, 2023 23:19
@darkdragon-001
Copy link

UX wise Tusky on Android is pretty good. One feature I like there in combination with this one here is that you can scroll to the top via click on the current menu item. Also it will automatically start from top after some time / after restarting the app?

@GeopJr
Copy link
Owner Author

GeopJr commented May 11, 2023

One feature I like there in combination with this one here is that you can scroll to the top via click on the current menu item

This has been suggested before and the main point was that such pattern is not found in any other GNOME app and might distort its (the view switcher's) expectations in other apps. Like GNOME Software or Music. There's already a scroll to top button anyway. This needs more thought but probably after #228

Also it will automatically start from top after some time / after restarting the app?

(I assume on Tuba, not tusky) This PR shouldn't cause any noticeable changes to users (apart from the scrolled window not moving around when new posts get added) so everything will work like it did before: On start, it starts at the top and at no point does it automatically change the scrolled position without the user triggering it (either through the scroll to top button or manually scrolling to the top)

Just to go a bit deeper on how this PR works in case it wasn't that clear:

(zoom in / open in new tab if the text is not visible)
prior to this PR:
Untitled-2023-05-11-0420

notice how the post you are reading "moved" below when a new post got added

after this PR:
Untitled-2023-05-11-0420(1)

@GeopJr GeopJr mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: do not scroll on new posts
2 participants