feat: cleanup #424
Merged
feat: cleanup #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we only use the account to get the name and the avatar, no point in storing it
we can use the setter instead
only used there
This reverts commit 585d045.
assuming the namespace is difficult for newcomers as one needs to have experience not only in all the namespaces but also the entire codebase
warning: libxml2 does not support HTML5 yet
using on_activate_link does an extra request, this should be faster as it avoids resolving the account
it's useless then, it's only used on manual auth
this used to be needed to avoid segfaults, it has been fixed however
this skips resolving the account, should be faster
ListStore needs objects so we can't create a const array of structs instead of converting a Locale[] to Gee.ArrayList<Locale> on start and then appending each one individually to a liststore every time we need to use them, create a list store of all of them (using splice) on construct and call construct on boot
instead of passing the whole media viewer to every item
cache can cause urls to be wrong - even when keys are the same
|
ListView needs some fixes still:
With ListViews we no longer have access to the widgets so we have to think of other ways to dynamically modify them - like for thread lines, it has to be saved in API.Status but only be visible in threads and when it's not expanded. edit: Additionally the style of the rows had to change to a card-like one which matches #228 |
|
Profiles are a bit weird. I have to use the header factory for the cover however it doesn't play well with pull to refresh :/ |
snap doesn't have the latest runtime yet
|
I need to merge this as is and continue on the rest as individual PRs as I need the new widgets to continue. If you are a user, the nightlies from now until GNOME 45 will depend on the master runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to go through as much as I can and clean up, optimize & simplify anything I find
Especially:
Move complicated UIs to Builder filesRemove widgets that are obsoleteAvoid abusing bindings and signalsfix: #57
close: #128
fix: #179
fix: #313 (?)