Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preferences): organization #507

Merged
merged 6 commits into from
Sep 18, 2023
Merged

feat(preferences): organization #507

merged 6 commits into from
Sep 18, 2023

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Sep 17, 2023

I still think that there are too many options, especially under Appearance but it's somewhat more organized

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
make the switch match the visibility state
@LukaszH77
Copy link
Contributor

I like it!

If you think there are still too many options, maybe Appearance could get it's own tab?

@GeopJr
Copy link
Owner Author

GeopJr commented Sep 17, 2023

Ideally I'd like to split Appearance into smaller groups (on its own tab), I'm unsure about the groups:

pref

#ff0000 fonts
#00ff00 emojis
#0000ff media
#ff00ff posts?

but some of the rows don't really fit :/ letterbox media and expand pictures in media viewer are both about media but on very different contexts (posts vs media viewer). Fonts and emojis could also be included under posts, color scheme will be a single row

Looking at other apps, Megalodon groups them into three categories: Visual Appearance, Behavior and Timelines. I think that also suffers from this.

Mastodon web is all-over the place. Elk splits it into Interface (for colors, fonts) and Preferences (for everything else)

@GeopJr
Copy link
Owner Author

GeopJr commented Sep 18, 2023

I'll merge this as is at the moment and will revisit it again in the future!

@GeopJr GeopJr merged commit 14c9992 into main Sep 18, 2023
@GeopJr GeopJr deleted the feat/preferences/organization branch September 18, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants