Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MediaViewer): add alternative shortcuts for zoom #712

Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat(MediaViewer): add alternative shortcuts for zoom #712

merged 2 commits into from
Dec 20, 2023

Conversation

oscfdezdz
Copy link
Contributor

No description provided.

@GeopJr
Copy link
Owner

GeopJr commented Dec 20, 2023

LGTM Thanks!

Should it be both instead? Browsers seem to support both Ctrl_ Ctrl- and Ctrl+ Ctrl=

@oscfdezdz oscfdezdz changed the title fix(MediaViewer): zoom in shortcut feat(MediaViewer): add alternative shortcuts for zoom Dec 20, 2023
@oscfdezdz
Copy link
Contributor Author

oscfdezdz commented Dec 20, 2023

Ctrl_ and Ctrl= don't work for me, maybe it's a layout issue. There is Gdk.Key.undebar, I went with Gdk.Key.underscore but as I can't test them, I'm not sure if there are differences.

@GeopJr
Copy link
Owner

GeopJr commented Dec 20, 2023

(the problem was that it only allowed the ctrl mask, I added a second statement to allow both ctrl and ctrl+shfit)

@GeopJr GeopJr merged commit 1c41c1d into GeopJr:main Dec 20, 2023
5 checks passed
@oscfdezdz oscfdezdz deleted the fix/media_viewer/zoom-in-shortcut branch December 20, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants