fix: Make Tuba.Widgets.Avatar non-focusable (#729) #730
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! I'd rather Widgets.Avatar stays focusable. Its proper use is to act as a button, apart from the sidebar headerbar where it's in a MenuButton (and causes the double-focus). Instead setting that specific instance's can-focus to false sounds more appropriate to me, what do you think? Tuba/data/ui/views/sidebar/view.ui Lines 41 to 43 in 8a4708d |
Make Tuba.Widgets.Avatar non-focusable when used as a child button of accounts selector, to prevent it from being selected during tab-cycling. Otherwise, it is cycled duplicate to the selector itself.
mgorny
force-pushed
the
no-focus-avatar
branch
from
e54b40a to
aed1b1d
Compare
|
Thanks for the suggestion. I've updated the PR and confirmed that this variant also works. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Tuba.Widgets.Avatar non-focusable to prevent the child button of accounts selector from being selected during tab-cycling. It is duplicate to the accounts selector itself.
Closes #729