Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alex description added #247

Merged
merged 2 commits into from
Dec 8, 2024
Merged

alex description added #247

merged 2 commits into from
Dec 8, 2024

Conversation

kkouhkil
Copy link
Contributor

@kkouhkil kkouhkil commented Nov 8, 2024

Hi there,

I would like to at first thank you for this very useful repository and I would also like to let you know that I am brining in this pull request, the Alex Robot (with three types of end-effector) from Boardwalk Robotics to this repository.

Copy link
Collaborator

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kkouhkil!

Please include a Readme file that reports the source of these files, the license, and any modification with respect to the source. See this example: https://github.com/Gepetto/example-robot-data/tree/master/robots/a1_description

@nim65s
Copy link
Member

nim65s commented Nov 8, 2024

Hi @kkouhkil,
The meshes are 30MiB, could you try to reduce those a bit ? Meshlab and Blender are usually good solutions for this issue.

@kkouhkil
Copy link
Contributor Author

Hi @kkouhkil, The meshes are 30MiB, could you try to reduce those a bit ? Meshlab and Blender are usually good solutions for this issue.

Hi there, thank you for your text. I did bring the size down to 19MiB, I would be appreciated to know if it is good enough as each mesh file is now under 1MiB.

@cmastalli cmastalli requested a review from nim65s November 12, 2024 09:38
@nim65s
Copy link
Member

nim65s commented Nov 14, 2024

This is still big :/

I had a look at the meshes, and I think there is no reason to be that big. And then I found that these are plain ASCII files. I should have seen it earlier, sorry.

With https://github.com/Neizvestnyj/stl-to-obj it seems easy to go down to 11M. Can you do that, and check everything is still OK for your use case ?

@nim65s
Copy link
Member

nim65s commented Dec 5, 2024

I'll handle it and make a release I think

@nim65s nim65s mentioned this pull request Dec 6, 2024
@nim65s
Copy link
Member

nim65s commented Dec 6, 2024

ref. #254

@nim65s nim65s closed this Dec 6, 2024
@nim65s nim65s reopened this Dec 8, 2024
@nim65s
Copy link
Member

nim65s commented Dec 8, 2024

I don't have time for now, so let's merge it. I'll deal with the excessive size in another way.

@nim65s nim65s merged commit 4acf557 into Gepetto:devel Dec 8, 2024
2 checks passed
nim65s added a commit to nim65s/robotpkg that referenced this pull request Dec 8, 2024
    ## [4.2.0] - 2024-12-08

    ### Added
    - Add PR2 robots ([210](Gepetto/example-robot-data#210))
    - Add GO2 robots ([239](Gepetto/example-robot-data#239))
    - Add Falcon Bravo7 Bluevolta robots ([244](Gepetto/example-robot-data#244))
    - Add alex robots ([247](Gepetto/example-robot-data#247))
    - Add compatibility with jrl-cmakemodules workspace ([225](Gepetto/example-robot-data#225))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants