Skip to content

Commit

Permalink
Extract common logic from cc.roundTrip
Browse files Browse the repository at this point in the history 
- http2ClientConn's roundTrip method is responsible for sending a
request and receiving the response. In the h2c upgrade case, we already
sent the request via HTTP/1, so we only need the logic for recovering
the response
- This way `cc.roundTrip` and `cc.completeUpgrade` can share the common
response-handling logic
- Remove the retry logic from CompleteUpgrade (which we copied from
RoundTripOpt), since we are not issuing a request (as described above)

[cloudfoundry/routing-release#200]

Co-authored-by: Greg Cobb <[email protected]>
  • Loading branch information
@ctlong @Gerg
ctlong and Gerg committed May 14, 2021
1 parent f8c0495 commit d981599
Showing 1 changed file with 26 additions and 129 deletions.
155 changes: 26 additions & 129 deletions http/h2_bundle.go
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d981599

Please sign in to comment.