Skip to content

Commit

Permalink
Add step to SUBMITTING_PATCHES to ensure Change-Id
Browse files Browse the repository at this point in the history
Add a step to SUBMITTING_PATCHES to ensure each commit message has a
Change-Id.

Change-Id: Ib44bc519538e304dddd6332d4a99034fc56638b3
  • Loading branch information
jlmuir committed Jan 11, 2018
1 parent f5061ee commit 0727947
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions SUBMITTING_PATCHES
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Short Version:
- Make small logical changes.
- Provide a meaningful commit message.
- Make sure all code is under the Apache License, 2.0.
- Make sure all commit messages have a Change-Id.
- Publish your changes for review:

git push https://gerrit.googlesource.com/gerrit HEAD:refs/for/master
Expand Down Expand Up @@ -67,6 +68,13 @@ Ensure you have obtained a unique HTTP password to identify yourself:

https://gerrit-review.googlesource.com/#/settings/http-password

Ensure you have installed the commit-msg hook that automatically
generates and inserts a Change-Id line during "git commit". This can
be done from the root directory of the local Git repository:

curl -Lo .git/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg
chmod +x .git/hooks/commit-msg

Push your patches over HTTPS to the review server, possibly through
a remembered remote to make this easier in the future:

Expand Down

0 comments on commit 0727947

Please sign in to comment.