refactor(components-native): surface--element instead of background as background color for non surface/container components #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
0b30717
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13e11fe7.atlantis.pages.dev |
| Branch Preview URL: | https://job-111369-do-it-components-jphz.atlantis.pages.dev |
…9-do-it-components-native
chris-at-jobber
requested changes
Dec 11, 2024
| @@ -29,6 +29,6 @@ export const styles = StyleSheet.create({ | |||
| padding: tokens["space-smaller"], | |||
| }, | |||
| activeDismissIcon: { | |||
| backgroundColor: tokens["color-surface--background"], | |||
| backgroundColor: tokens["color-interactive--background"], | |||
There was a problem hiding this comment.
I don't actually recall why we need a different background color here, but that's probably a question for another day
| @@ -14,7 +14,7 @@ export const styles = StyleSheet.create({ | |||
| height: BAR_HEIGHT, | |||
| }, | |||
| lightTheme: { | |||
| backgroundColor: tokens["color-surface--background"], | |||
| backgroundColor: tokens["color-interactive--background"], | |||
There was a problem hiding this comment.
Suggested change
| backgroundColor: tokens["color-interactive--background"], | |
| backgroundColor: tokens["color-surface--background"], |
This is the toolbar above the native keyboard for things like the "Done" button, this isn't a "UI element" in the sense of the other components here
| @@ -7,7 +7,7 @@ export const styles = StyleSheet.create({ | |||
| justifyContent: "space-between", | |||
| alignItems: "center", | |||
| paddingHorizontal: tokens["space-small"], | |||
| backgroundColor: tokens["color-surface--background"], | |||
| backgroundColor: tokens["color-interactive--background"], | |||
There was a problem hiding this comment.
Suggested change
| backgroundColor: tokens["color-interactive--background"], | |
| backgroundColor: tokens["color-surface--background"], |
Fairly sure this is related to the same element as the previous file
chris-at-jobber
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2227
Motivations
surface--backgroundhave poor contrast on some surfacesChanges
surface--backgroundnow have better visibility on all surfacesChipin components-native will need a followup task to set background color for inactive state tosurface--elementinstead of using theinactiveBackgroundColorprop.Added
Changed
color-surface--backgroundto usecolor-surface--elementinsteadDeprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.