Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Co-Pilot Instructions First Pass #2294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scotttjob
Copy link
Contributor

Motivations

Github Copilot has rolled out some new functionality to leverage a set of instructions on every prompt while working within a repository.

https://docs.github.com/en/copilot/customizing-copilot/adding-custom-instructions-for-github-copilot

This PR is a first-pass attempt at encoding some Atlantis-specific direction for Copilot to leverage.

I took a pass at high-level information as suggested by the documentation, then I worked with co-pilot a bit locally to format those steps into a format that it prefers (mainly added the bolding in the title, and formatting for the bullet points).

I then generated some changes along with the document to refine further (function over arrow definition, documentation for interface properties).

Very much open to feedback if you feel the instructions should include (or not include) any information.

Added

  1. Github Copilot instructions

Testing

  1. If you pull this branch down locally, and ask Copilot a question within vscode, it will automatically add the contents of copilot-instructions.md to your prompt.
  2. There are instructions in the Github documentation above for enabling/disabling instructions within vscode, if you wanted to test toggling on and toggling off.

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

5. **Accessibility**:

- Consider accessibility in all code.
- Use ARIA roles and properties where applicable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "prefer HTML-native roles and attributes, and use ARIA roles only as necessary" or something? I guess "where applicable" already gets at that, but I wonder how the LLM reads that in practice (ie will it take that as a sign to prefer ARIA roles?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

- Consider accessibility in all code.
- Use ARIA roles and properties where applicable.

6. **Comments and Documentation**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to train it on our own guides for docs? Like

  • reference [our docs guides](url to docs guides) when reviewing changes to documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

cloudflare-workers-and-pages bot commented Jan 9, 2025

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a08c1c
Status: ✅  Deploy successful!
Preview URL: https://95896bd1.atlantis.pages.dev
Branch Preview URL: https://scott-t-copilot-instructions.atlantis.pages.dev

View logs

Copy link
Contributor

@jdeichert jdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I gave this a read and pulled it locally, my copilot picks it up when I ask questions related to the codebase 👍

It's difficult for me to understand whether we need more info here or not. It looks fine to me, but really it's hard to judge how well it works for copilot! 😅

Approved. We can always improve with more info over time.

@scotttjob
Copy link
Contributor Author

Nice! I gave this a read and pulled it locally, my copilot picks it up when I ask questions related to the codebase 👍

It's difficult for me to understand whether we need more info here or not. It looks fine to me, but really it's hard to judge how well it works for copilot! 😅

Approved. We can always improve with more info over time.

Yeah it'll be interesting to keep an eye on it over time. I'd like to encourage the team to experiment with their own adjustments to it, and recommend changes if they find a new addition (or the removal of something in here) to be a useful change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants