-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): Co-Pilot Instructions First Pass #2294
base: master
Are you sure you want to change the base?
Conversation
.github/copilot-instructions.md
Outdated
5. **Accessibility**: | ||
|
||
- Consider accessibility in all code. | ||
- Use ARIA roles and properties where applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "prefer HTML-native roles and attributes, and use ARIA roles only as necessary" or something? I guess "where applicable" already gets at that, but I wonder how the LLM reads that in practice (ie will it take that as a sign to prefer ARIA roles?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
- Consider accessibility in all code. | ||
- Use ARIA roles and properties where applicable. | ||
|
||
6. **Comments and Documentation**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to train it on our own guides for docs? Like
- reference [our docs guides](url to docs guides) when reviewing changes to documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not! They explicitly call that out as something that doesn't work: https://docs.github.com/en/copilot/customizing-copilot/adding-custom-instructions-for-github-copilot#writing-effective-custom-instructions
Deploying atlantis with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I gave this a read and pulled it locally, my copilot picks it up when I ask questions related to the codebase 👍
It's difficult for me to understand whether we need more info here or not. It looks fine to me, but really it's hard to judge how well it works for copilot! 😅
Approved. We can always improve with more info over time.
Yeah it'll be interesting to keep an eye on it over time. I'd like to encourage the team to experiment with their own adjustments to it, and recommend changes if they find a new addition (or the removal of something in here) to be a useful change. |
Motivations
Github Copilot has rolled out some new functionality to leverage a set of instructions on every prompt while working within a repository.
https://docs.github.com/en/copilot/customizing-copilot/adding-custom-instructions-for-github-copilot
This PR is a first-pass attempt at encoding some Atlantis-specific direction for Copilot to leverage.
I took a pass at high-level information as suggested by the documentation, then I worked with co-pilot a bit locally to format those steps into a format that it prefers (mainly added the bolding in the title, and formatting for the bullet points).
I then generated some changes along with the document to refine further (function over arrow definition, documentation for interface properties).
Very much open to feedback if you feel the instructions should include (or not include) any information.
Added
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.