Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update chewie to newest version #905

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

S-ecki
Copy link
Contributor

@S-ecki S-ecki commented Feb 18, 2022

fixes issue #805

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

I only increased the chewie version, no additional tests are needed. Existing tests pass

Description of the pull request

  • Updated chewie version to 1.3.0
  • Done to prevent dependency problems with BloC version (Provider versions of chewie and BloC were not compatible)

closes #805

@S-ecki S-ecki changed the title update chewie to newest version fix: update chewie to newest version Feb 18, 2022
@xsahil03x xsahil03x changed the title fix: update chewie to newest version fix(ui): update chewie to newest version Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #905 (f318b61) into develop (141c130) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    76.08%   76.08%           
========================================
  Files          192      192           
  Lines        20640    20640           
========================================
  Hits         15704    15704           
  Misses        4936     4936           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141c130...f318b61. Read the comment docs.

@xsahil03x
Copy link
Member

Hey @S-ecki , can you also update the StreamChatFlutter changelog? Thanks.

@xsahil03x xsahil03x changed the title fix(ui): update chewie to newest version feat(ui): update chewie to newest version Feb 18, 2022
@S-ecki
Copy link
Contributor Author

S-ecki commented Feb 18, 2022

Hey @xsahil03x, I updated the changelog, hope I did it right

@xsahil03x xsahil03x changed the title feat(ui): update chewie to newest version fix(ui): update chewie to newest version Feb 21, 2022
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HayesGordon HayesGordon merged commit 5e29418 into GetStream:develop Feb 21, 2022
@HayesGordon
Copy link
Contributor

Hi @S-ecki, thank you for contributing 🙂. We're really happy that this issue is finally resolved.

@S-ecki
Copy link
Contributor Author

S-ecki commented Feb 21, 2022

@HayesGordon No problem, I am happy to contribute!

By the way, thanks for your Flutter Stream Chat Series! It really helped me in getting the application up and running. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chewie dependency (Provider dependency) needs updated
3 participants