Merge pull request #256 from GetStream/vishal/remove-event-listener

Allow .off() on uninitialized channels
GetStream · Feb 13, 2020 · 985155f · 985155f
2 parents 6889596 + 7ad89b5
commit 985155f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/channel.js b/src/channel.js
@@ -769,7 +769,6 @@ export class Channel {
 	 *
 	 */
 	off(callbackOrString, callbackOrNothing) {
-		this._checkInitialized();
 		const key = callbackOrNothing ? callbackOrString : 'all';
 		const valid = isValidEventType(key);
 		if (!valid) {

diff --git a/test/test.js b/test/test.js
@@ -1933,6 +1933,23 @@ describe('Chat', function() {
 				);
 			}
 		});
+
+		it('should allow .off() on unwatched channels', () => {
+			const client = getTestClient(false);
+			const userID = uuidv4();
+
+			client.setUser({ id: userID }, createUserToken(userID));
+			const channel = client.channel('messaging', uuidv4());
+			let result;
+			try {
+				channel.off('message.new');
+				result = true;
+			} catch (e) {
+				result = false;
+			}
+
+			expect(result).to.be.ok;
+		});
 	});
 
 	describe('Channel State', function() {