Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types of fields in ChannelSort #941

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

khushal87
Copy link
Member

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why, and How?

Fixes #915

Changelog

  • Added appropriate type to ChannelSort.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Size Change: 0 B

Total Size: 298 kB

ℹ️ View Unchanged
Filename Size Change
dist/browser.es.js 65.3 kB 0 B
dist/browser.full-bundle.min.js 35.7 kB 0 B
dist/browser.js 66 kB 0 B
dist/index.es.js 65.4 kB 0 B
dist/index.js 66.1 kB 0 B

compressed-size-action

@khushal87 khushal87 requested a review from petyosi April 5, 2022 05:14
@vishalnarkhede
Copy link
Contributor

Gonna merge this right after we sort out ts stuff #942

@vishalnarkhede vishalnarkhede merged commit d8a2d38 into master Apr 5, 2022
@vishalnarkhede vishalnarkhede deleted the khushal87-channel-type-fix branch April 5, 2022 19:19
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChannelSort<StreamChatGenerics> looks at the wrong fields
2 participants