Adding missing types #296
Merged
Adding missing types #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
reviewed
Apr 9, 2020
| @@ -42,6 +46,8 @@ const executables = [ | |||
| { f: rg.getReactions, type: 'GetReactionsAPIResponse' }, | |||
| { f: rg.updateChannel, type: 'UpdateChannelAPIResponse' }, | |||
| { f: rg.deleteChannel, type: 'DeleteChannelAPIResponse' }, | |||
| /** Keeping truncate quite for now. Needs some fixes on backend regardind commands array in response */ | |||
There was a problem hiding this comment.
typo and could you explain what is needed to be fixed?
There was a problem hiding this comment.
commands is different in truncateChannel response. It should be array of objects :)
Marcelo has fixed it. It will be deployed by tomorrow
There was a problem hiding this comment.
yes, I saw the discussion with Mike and it's good to have a reference. I think this comment is enough, no need write in source since it will be updated soon.
ferhatelmas
reviewed
Apr 9, 2020
| @@ -75,6 +75,16 @@ async function deleteChannel() { | |||
| return await channel.delete(); | |||
| } | |||
|
|
|||
| async function truncateChannel() { | |||
There was a problem hiding this comment.
but generator is added ?
There was a problem hiding this comment.
Yeah thats fine. Once backend fix is ready, we will use it anyways!
mksglu
pushed a commit
to mksglu/stream-chat-js
that referenced
this pull request
Jun 13, 2020
Types/files images
kevinnath1007
pushed a commit
to kevinnath1007/stream-chat-js
that referenced
this pull request
Aug 31, 2022
build: v1.30.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request