Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for channel, member, and user values in Event interface #304

Merged
merged 4 commits into from May 15, 2020
Merged

Fix types for channel, member, and user values in Event interface #304

merged 4 commits into from May 15, 2020

Conversation

walberty
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Fixed TypeScript interface definition for Event to reflect actual types of ChannelResponse and UserResponse API response objects instead of the Channel and User classes.

types/stream-chat/index.d.ts Outdated Show resolved Hide resolved
@walberty walberty requested a review from vishalnarkhede April 17, 2020 16:49
Copy link
Contributor

@vishalnarkhede vishalnarkhede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @walberty . Will include it in next patch release :)

@vishalnarkhede vishalnarkhede merged commit 891b01c into GetStream:master May 15, 2020
kevinnath1007 pushed a commit to kevinnath1007/stream-chat-js that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants