Fixed File interface and improve contentType #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mksglu thanks for the pr, can you run |
kevinnath1007
pushed a commit
to kevinnath1007/stream-chat-js
that referenced
this pull request
Aug 31, 2022
fix: fix wrong render function in the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File interface is not part of Javascript (node.js); it belongs to Web APIs. So, the File is not available in your node.js application.
sendFilemay be used in different parts on the client-side or in some SDKs. So instead of removing this line, we should add some conditions. And this code actually does accept mime-type as 3rd argument but is in a different case. I think we can use this control a little more flexibly. #239