warm up connection #399
Merged
warm up connection #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +296 B (0%) Total Size: 191 kB
|
tbarbugli
reviewed
Aug 12, 2020
src/client.js
Outdated
| @@ -56,6 +56,7 @@ export class StreamChat { | |||
| const defaultOptions = { | |||
| timeout: 3000, | |||
| withCredentials: false, // making sure cookies are not sent | |||
| warmUp: true, | |||
There was a problem hiding this comment.
lets roll with this disabled first
src/client.js
Outdated
| const handshake = await this.wsConnection.connect(); | ||
| this.connectionID = this.wsConnection.connectionID; | ||
| if (this.options.warmUp) { | ||
| // wait for warm up connection to complete | ||
| await warmUp; |
There was a problem hiding this comment.
I think a fire and forget is better for this
…r since it ends on proxy)
src/client.js
Outdated
| @@ -56,6 +56,7 @@ export class StreamChat { | |||
| const defaultOptions = { | |||
| timeout: 3000, | |||
| withCredentials: false, // making sure cookies are not sent | |||
| warmUp: false, | |||
There was a problem hiding this comment.
can we add a code comment about what does this mean exactly?
ferhatelmas
reviewed
Aug 13, 2020
| createUserToken(user), | ||
| ); | ||
|
|
||
| let t0 = new Date().getTime(); |
There was a problem hiding this comment.
using performance would be better for more accurate numbers since uses counters for relative time than real time system
ruudniew
suggested changes
Sep 7, 2020
src/client.js
Outdated
| @@ -491,6 +492,9 @@ export class StreamChat { | |||
| case 'patch': | |||
| response = await this.axiosInstance.patch(url, data, requestConfig); | |||
| break; | |||
| case 'options': | |||
| response = await this.axiosInstance.options(url); | |||
There was a problem hiding this comment.
Suggested change
| response = await this.axiosInstance.options(url); | |
| response = await this.axiosInstance.options(url, requestConfig); |
The api_key request header should be included, so the preflight request doesn't fail
…mup-tls-conn # Conflicts: # src/client.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request