Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests and correct types for BlockList #455

Merged
merged 1 commit into from
Oct 2, 2020
Merged

add tests and correct types for BlockList #455

merged 1 commit into from
Oct 2, 2020

Conversation

nhannah
Copy link
Contributor

@nhannah nhannah commented Oct 2, 2020

Description of the pull request

Adds typescript tests and corrects types for blocklist functions

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2020

Size Change: 0 B

Total Size: 194 kB

ℹ️ View Unchanged
Filename Size Change
dist/browser.es.js 41.3 kB 0 B
dist/browser.full-bundle.min.js 27 kB 0 B
dist/browser.js 41.9 kB 0 B
dist/index.es.js 41.4 kB 0 B
dist/index.js 41.9 kB 0 B

compressed-size-action

ferhatelmas
ferhatelmas approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhannah nhannah merged commit b52ed3b into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-block-list-tests branch October 2, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhannah @ferhatelmas