Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary _initializeState call in watch() #473

Merged
merged 1 commit into from
Oct 21, 2020
Merged

remove unnecessary _initializeState call in watch() #473

merged 1 commit into from
Oct 21, 2020

Conversation

mahboubii
Copy link
Contributor

@github-actions
Copy link
Contributor

Size Change: -20 B (0%)

Total Size: 197 kB

Filename Size Change
dist/browser.es.js 41.8 kB -3 B (0%)
dist/browser.full-bundle.min.js 28.5 kB -6 B (0%)
dist/browser.js 42.3 kB -4 B (0%)
dist/index.es.js 41.8 kB -4 B (0%)
dist/index.js 42.4 kB -3 B (0%)

compressed-size-action

@mahboubii mahboubii requested a review from ferhatelmas October 21, 2020 08:39
ferhatelmas
ferhatelmas approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahboubii mahboubii merged commit facc8a5 into master Oct 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/duplicate-channel-initializeState branch October 21, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

@ferhatelmas ferhatelmas ferhatelmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahboubii @ferhatelmas @vishalnarkhede