Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding types for translations #607

Merged
merged 3 commits into from
Feb 1, 2021
Merged

adding types for translations #607

merged 3 commits into from
Feb 1, 2021

Conversation

virdesai
Copy link
Contributor

@virdesai virdesai commented Feb 1, 2021

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 214 kB

ℹ️ View Unchanged
Filename Size Change
dist/browser.es.js 46.4 kB 0 B
dist/browser.full-bundle.min.js 27.3 kB 0 B
dist/browser.js 46.9 kB 0 B
dist/index.es.js 46.4 kB 0 B
dist/index.js 47 kB 0 B

compressed-size-action

ferhatelmas
ferhatelmas reviewed Feb 1, 2021
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@virdesai virdesai merged commit 7515f35 into remove-immutable Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the translation_types branch February 1, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@DanC5 DanC5 DanC5 approved these changes

@nhannah nhannah nhannah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@virdesai @nhannah @ferhatelmas @DanC5