Ensure mentioned_users is array of user_ids. in updateMessage #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +609 B (0%) Total Size: 217 kB
|
vishalnarkhede
requested review from
mahboubii,
AnatolyRugalev,
nhannah,
ferhatelmas,
DanC5 and
petyosi
and removed request for
mahboubii
vishalnarkhede
force-pushed
the
vishal/mentioned-users
branch
from
7f9bbb3 to
309e965
Compare
mahboubii
previously approved these changes
Mar 17, 2021
AnatolyRugalev
previously approved these changes
Mar 17, 2021
ferhatelmas
reviewed
Mar 17, 2021
mahboubii
reviewed
Mar 17, 2021
…chat-js into vishal/mentioned-users
vishalnarkhede
dismissed stale reviews from AnatolyRugalev and mahboubii
via
4b2d7b8
mahboubii
previously approved these changes
Mar 17, 2021
vishalnarkhede
dismissed stale reviews from ferhatelmas and mahboubii
via
b2d4707
vishalnarkhede
force-pushed
the
vishal/mentioned-users
branch
from
dd0500f to
b2d4707
Compare
ferhatelmas
approved these changes
Mar 17, 2021
lol yeah, thats typical "Vish" :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Slack discussion - https://getstream.slack.com/archives/C01FT5767AS/p1615968119001100
Updating pinned message fails, if there is mentioned_users in message. This is something missed in react sdk, (to ensure conversion of array of user objects to user ids). I think its better we handle it on js client as well.
Changelog
message.mentioned_usersis array of string or objects