Fix/thread loading bug and message update bug #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.83 kB (0%) Total Size: 233 kB
|
|
Never mind, this is a different issue |
vishalnarkhede
previously approved these changes
Jul 13, 2021
Co-authored-by: Vishal Narkhede <[email protected]>
vishalnarkhede
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the SDKs rely on the current message state to determine when and what they should reload there were multiple edge cases currently present that could cause issues with loading. Updates, and deletions to both messages and thread messages could add to the message list messages which were out of sync with the current desired state. These caused the loading logic to function incorrectly as it is dependent on the currently loaded state for pagination.
This situation also arose with messages in that are shown both in a thread and in the main channel. They would be loaded for the main channel but also added to the thread, these randomly added thread messages could cause the loading logic for threads to also get out of sync.
These fixes address these edge cases to keep a state more inline with that desired by the SDKs and users.