-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: convert Generics into a single Generic #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -1.19 kB (0%) Total Size: 284 kB
ℹ️ View Unchanged
|
mahboubii
requested review from
AnatolyRugalev,
gumuz,
vini-btc and
vishalnarkhede
as code owners
December 3, 2021 15:57
mahboubii
changed the title
BREAKING: Refactor Generics into Single Generic
BREAKING CHANGE: Refactor Generics into Single Generic
Jan 31, 2022
mahboubii
changed the title
BREAKING CHANGE: Refactor Generics into Single Generic
refactor!: Convert Generics into a Single Generic
Jan 31, 2022
mahboubii
changed the title
refactor!: Convert Generics into a Single Generic
refactor!: convert Generics into a single Generic
Jan 31, 2022
khushal87
approved these changes
Feb 10, 2022
vishalnarkhede
approved these changes
Feb 11, 2022
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
Currently internal generics are verbose and hard to maintain, with this change we move to a single generic type passed into StreamChat by users which get passed around easily in internal functions. We also no longer need to maintain the generics order. This PR includes no JS changes.
based on the great work here #752
Changelog