-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automated release flow #866
Conversation
dae484b
to
cbbcf91
Compare
Size Change: 0 B Total Size: 282 kB ℹ️ View Unchanged
|
6b0dc96
to
881aa85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff 👍
7b243f7
to
589c99e
Compare
.github/workflows/lint.yml
Outdated
- uses: ./.github/actions/setup-node | ||
|
||
- uses: wagoid/commitlint-github-action@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this linter verifies all the commits right? we dont really need to do this since we always squash the commits and merge into master, we need a linter to confirm the pull request title which is used for the commit message in upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about now @mahboubii? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
ef46699
to
f978a4e
Compare
12cce45
to
0eeeb5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@peterdeme token is there in CI, we can merge. Also, could you remove Amin from codeowners? |
ea78505
ea78505
to
1a72b67
Compare
1a72b67
to
3a67c22
Compare
Add automated release flow