Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listen to correct channel read events #2795

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: listen to correct channel read events #2795

merged 1 commit into from
Nov 19, 2024

Conversation

isekovanic
Copy link
Contributor

🎯 Goal

Reverts back to the changes discussed in this Slack thread (thanks @myandrienko ).

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

SDK Size

title develop branch diff status
js_bundle_size 452 KB 455 KB +2624 B 🔴

@isekovanic isekovanic merged commit ec3ebbd into v6.0.0 Nov 19, 2024
5 of 7 checks passed
@isekovanic isekovanic deleted the fix/listen-to-correct-read-events branch November 19, 2024 17:42
@isekovanic isekovanic mentioned this pull request Nov 19, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlaz oliverlaz Awaiting requested review from oliverlaz

@khushal87 khushal87 Awaiting requested review from khushal87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isekovanic @Stream-SDK-Bot