Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bottom sheet layout issue interrupting with animated view #2917

Merged
merged 1 commit into from
Jan 30, 2025
+4 −4
Merged

fix: bottom sheet layout issue interrupting with animated view #2917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
fix: bottom sheet layout issue interrupting with animated view
@khushal87
khushal87 committed Jan 30, 2025
commit 0bfe9b6299346b563f60cf05b839a47cc0c9f791
8 changes: 4 additions & 4 deletions package/src/components/UIComponents/BottomSheetModal.tsx
View file
Original file line number Diff line number Diff line change
@@ -119,8 +119,8 @@ export const BottomSheetModal = (props: PropsWithChildren<BottomSheetModalProps>
});

return (
<Modal animationType='fade' onRequestClose={handleDismiss} transparent visible={visible}>
<GestureHandlerRootView style={{ flex: 1 }}>
<GestureHandlerRootView style={{ flex: 1 }}>
<Modal animationType='fade' onRequestClose={handleDismiss} transparent visible={visible}>
<TouchableWithoutFeedback onPress={handleDismiss}>
<View style={[styles.overlay, { backgroundColor: overlay }, overlayTheme]}>
<GestureDetector gesture={gesture}>
@@ -143,8 +143,8 @@ export const BottomSheetModal = (props: PropsWithChildren<BottomSheetModalProps>
</GestureDetector>
</View>
</TouchableWithoutFeedback>
</GestureHandlerRootView>
</Modal>
</Modal>
</GestureHandlerRootView>
);
};