feat: increase and support overriding jump to message limit #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1718 +/- ##
===========================================
- Coverage 79.65% 79.63% -0.03%
===========================================
Files 229 229
Lines 5795 5794 -1
Branches 1642 1642
===========================================
- Hits 4616 4614 -2
- Misses 1038 1039 +1
Partials 141 141
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arnautov-anton
approved these changes
Aug 19, 2022
MartinCupela
approved these changes
Aug 19, 2022
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2022
# [9.5.0](v9.4.1...v9.5.0) (2022-08-29) ### Bug Fixes * include mdast-util-find-and-replace into our CJS bundle ([#1702](#1702)) ([61c4eec](61c4eec)), closes [#1698](#1698) * prevent double submissions in korean ([#1720](#1720)) ([5d781d8](5d781d8)) * replace FileReader with URL.createObjectURL ([#1701](#1701)) ([c8a490e](c8a490e)) * **Vite:** add emoji-mart (emoji, picker) re-export ([#1724](#1724)) ([c90cf4b](c90cf4b)) ### Features * increase and support overriding jump to message limit ([#1718](#1718)) ([8c720f4](8c720f4))
|
🎉 This PR is included in version 9.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
# [10.0.0-theming-v2.3](v10.0.0-theming-v2.2...v10.0.0-theming-v2.3) (2022-09-06) ### Bug Fixes * include mdast-util-find-and-replace into our CJS bundle ([#1702](#1702)) ([#1703](#1703)) ([8010889](8010889)), closes [#1698](#1698) * prevent double submissions in korean ([#1720](#1720)) ([5d781d8](5d781d8)) * ThemingV2 beta adjustments ([#1728](#1728)) ([785ee11](785ee11)) * **ThemingV2:** MessageInputFlat missing lodash/zipObject ([#1721](#1721)) ([dd8a457](dd8a457)) * **Vite:** add emoji-mart (emoji, picker) re-export ([#1724](#1724)) ([c90cf4b](c90cf4b)) ### Features * increase and support overriding jump to message limit ([#1718](#1718)) ([8c720f4](8c720f4)) * **ThemingV2:** PopperTooltip component ([#1714](#1714)) ([9b6301e](9b6301e))
|
🎉 This PR is included in version 10.0.0-theming-v2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The default limit of 25 can be too small for tall screens (or short items), causing additional queryChannel request and potential scroll glitches.
🛠 Implementation details
Introduce an additional parameter for jumpToMessage, defaulting it to 100 (default value for pagination).
🎨 UI Changes