Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark channel read on scroll to bottom of the main message list #2283

Merged
merged 12 commits into from
Feb 21, 2024

fix: include missing effect deps for useUnreadMessagesNotification

93cb9ed
Select commit
Loading
Failed to load commit list.
Merged

fix: mark channel read on scroll to bottom of the main message list #2283

fix: include missing effect deps for useUnreadMessagesNotification
93cb9ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2024 in 0s

85.02% (target 70.00%)

View this Pull Request on Codecov

85.02% (target 70.00%)

Details

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (7867677) 84.85% compared to head (93cb9ed) 85.02%.

Files Patch % Lines
src/components/Channel/Channel.tsx 80.76% 3 Missing and 2 partials ⚠️
...ponents/MessageList/UnreadMessagesNotification.tsx 33.33% 1 Missing and 1 partial ⚠️
...mponents/ChannelList/hooks/usePaginatedChannels.ts 0.00% 0 Missing and 1 partial ⚠️
...components/MessageList/UnreadMessagesSeparator.tsx 75.00% 0 Missing and 1 partial ⚠️
src/components/MessageList/hooks/useMarkRead.ts 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
+ Coverage   84.85%   85.02%   +0.17%     
==========================================
  Files         344      344              
  Lines        7592     7675      +83     
  Branches     2103     2135      +32     
==========================================
+ Hits         6442     6526      +84     
+ Misses        807      805       -2     
- Partials      343      344       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov