Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for own_reactions in EnrichedActivity #397

Closed
hannojg opened this issue Nov 12, 2020 · 2 comments
Closed

Wrong type for own_reactions in EnrichedActivity #397

hannojg opened this issue Nov 12, 2020 · 2 comments
Assignees
Labels

Comments

@hannojg
Copy link

hannojg commented Nov 12, 2020

Hey,

own_reactions seems to have the same structure as e.g. latest_reactions. However, the own_reactions are said to be an array (while all other reaction records aren't). I believe that this is a mistake, compare for example:

Line 111:

own_reactions?: ReactionsRecords<ReactionType, ChildReactionType, UserType>[];

and
Line 109:
latest_reactions?: ReactionsRecords<ReactionType, ChildReactionType, UserType>;

thanks in advance for looking into this ✌️

gz#7333

@mahboubii mahboubii added the bug label Nov 13, 2020
@mahboubii mahboubii self-assigned this Nov 13, 2020
@mahboubii
Copy link
Contributor

@hannojg Thanks for reporting this.

mahboubii added a commit that referenced this issue Nov 13, 2020
@shodgetts
Copy link

Agent comment from ferhat elmas in Zendesk ticket #7333:

This is released as 6.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants