Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade axios to v0.22 #484

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Chore: Upgrade axios to v0.22 #484

merged 1 commit into from
Nov 29, 2021

Conversation

mahboubii
Copy link
Contributor

@mahboubii mahboubii commented Nov 29, 2021

high severity security issue GHSA-cph5-m8f7-6c5x

@github-actions
Copy link
Contributor

Size Change: -1.13 kB (1%)

Total Size: 98.1 kB

Filename Size Change
dist/js_min/getstream.js 30.7 kB -697 B (2%)
dist/js/getstream.js 67.4 kB -431 B (0%)

compressed-size-action

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -67,11 +67,11 @@ export class MissingSchemaError extends ErrorAbstract {}
* @param {object} data
* @param {object} response
*/
export class StreamApiError extends ErrorAbstract {
export class StreamApiError<T> extends ErrorAbstract {
Copy link
Collaborator

@arnautov-anton arnautov-anton Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No defaults (not sure if needed, just curious)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add later if needed, good for now

@arnautov-anton
Copy link
Collaborator

👍 🌮

@mahboubii mahboubii disabled auto-merge November 29, 2021 18:37
@mahboubii mahboubii merged commit 905ff95 into main Nov 29, 2021
@mahboubii mahboubii deleted the chore/upgrade-axios branch November 29, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants