fix: Update node binary package name (anchore#1375)

GijsCalis · Nov 30, 2022 · 5f1c25f · 5f1c25f
1 parent 08b0c9a
commit 5f1c25f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/syft/pkg/cataloger/binary/cataloger_test.go b/syft/pkg/cataloger/binary/cataloger_test.go
@@ -65,6 +65,18 @@ func TestClassifierCataloger_DefaultClassifiers_PositiveCases(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:       "positive-node",
+			fixtureDir: "test-fixtures/classifiers/positive",
+			expected: pkg.Package{
+				Name:      "node",
+				Version:   "19.2.1",
+				Locations: singleLocation("node"),
+				Metadata: pkg.BinaryMetadata{
+					Classifier: "nodejs-binary",
+				},
+			},
+		},
 		{
 			name:       "positive-go-hint",
 			fixtureDir: "test-fixtures/classifiers/positive",

diff --git a/syft/pkg/cataloger/binary/default_classifiers.go b/syft/pkg/cataloger/binary/default_classifiers.go
@@ -38,7 +38,7 @@ var defaultClassifiers = []classifier{
 		FileGlob: "**/node",
 		EvidenceMatcher: fileContentsVersionMatcher(
 			`(?m)node\.js\/v(?P<version>[0-9]+\.[0-9]+\.[0-9]+)`),
-		Package:  "node.js",
+		Package:  "node",
 		Language: pkg.JavaScript,
 		PURL:     mustPURL("pkg:generic/node@version"),
 		CPEs:     singleCPE("cpe:2.3:a:nodejs:node.js:*:*:*:*:*:*:*:*"),

diff --git a/syft/pkg/cataloger/binary/test-fixtures/classifiers/positive/node b/syft/pkg/cataloger/binary/test-fixtures/classifiers/positive/node
@@ -0,0 +1,2 @@
+# this should match node 19.2.1
+node.js/v19.2.1
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# this should match node 19.2.1
		node.js/v19.2.1