Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hidden "skip to main" link #8

Merged
merged 1 commit into from
Oct 30, 2022
Merged

feat: hidden "skip to main" link #8

merged 1 commit into from
Oct 30, 2022

Conversation

devils2ndself
Copy link
Contributor

Resolves #5

Implemented hidden "Skip to main content" link available for keyboard navigation users.

There are also some changes to HTML file to meet the global standards.

How to test:

When the page is opened, press "Tab" key on your keyboard. The link will appear from the top.

I also made a test branch that has some dummy nav and main content.

GingerKiwi
GingerKiwi approved these changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@GingerKiwi GingerKiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Your contribution is the first one for this repo. It's also my first time accepting a PR.

@GingerKiwi GingerKiwi added enhancement New feature or request hacktoberfest-accepted PR accepted during Hacktoberfest labels Oct 30, 2022
@GingerKiwi GingerKiwi merged commit 60b52ae into GingerKiwi:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GingerKiwi GingerKiwi GingerKiwi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted PR accepted during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add skip to main content in index.html
2 participants
@devils2ndself @GingerKiwi