Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadAsset and gifByID closure don't called on timeout #116

Closed
Igor-Poltavtsev opened this issue Nov 4, 2020 · 2 comments
Closed

downloadAsset and gifByID closure don't called on timeout #116

Igor-Poltavtsev opened this issue Nov 4, 2020 · 2 comments

Comments

@Igor-Poltavtsev
Copy link

Igor-Poltavtsev commented Nov 4, 2020 •
edited
Loading

GPHCache.shared.downloadAsset and GiphyCore.shared.gifByID closure don't called on timeout (e.g. no connection).
Is it a bug or we can get this notification in some other way?
Thank you.
@emrdgrmnci
Copy link

I am trying to save giphy gif added image to camera roll but I can't save with GPHCache.shared.downloadAsset and GiphyCore.shared.gifByID closures. Do you try save gif added image to camera roll?

@cgmaier
Copy link
Contributor

cgmaier commented Feb 4, 2021

hey @Igor-Poltavtsev we made this adjustment with the latest release. let us know if you have any issues!
https://github.com/Giphy/giphy-ios-sdk-ui-example/releases/tag/v2.1.2

@cgmaier cgmaier closed this as completed Feb 4, 2021
djrluna pushed a commit that referenced this issue Apr 21, 2021
@cgmaier
Merge pull request #116 from Giphy/task/revert-om-update
58fc37d 
revert OM update back to 1.2.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emrdgrmnci @cgmaier @Igor-Poltavtsev